Enable Full Screen Splash Images#7005
Conversation
|
I think it would be preferable (more efficient and smaller code) to use a binary format rather than parsing PPM. TGA is very simple and supports palettes. |
|
There may already be part of this implemented for uefi in drivers/video/fbdev/efifb.c for allowing a vendor specific bitmap to be passed in such that it can be merged into the boot screens. That's how you can get say "Asus" as the background whilst Ubuntu is starting. Loading the file using the |
pelwell
left a comment
pelwell
left a comment
There was a problem hiding this comment.
I'm not going to give this a full review until you've tidied it up some - it's too tiring otherwise.
A few kernel coding rules (see https://www.kernel.org/doc/html/v6.12/process/coding-style.html for more):
- Use TABs for indentation, with tab stops set to 8. Spaces can be used to precise alignment, but only after any TABs.
- You have the preferred brace style and no trailing whitespace, so that's good.
- Your local variable declarations are also pretty good, but for full marks put them in "reverse Christmas tree" format, longest to shortest, making sure there is a blank line before any statements.
- Make all local-scope functions
static, and ideally with a module-specific prefix. - Prefer
pr_info(ordev_info) overprintk(KERN_INFO.
scripts/checkpatch.pl -g <from-commit>..<to-commit> is your fussy friend.
I've had a look around the efifb.c file, and it looks like it's ultimately expecting the data from the ACPI Boot Graphics Resource Table - which following a conversation with Tom, looks like a path we don't want to go down. |
I was more thinking if we have the BMP parser etc already in the kernel, it'd be nicer for that to be abstracted out and reused. |
bebon901
force-pushed
the
cmdline-working-splash
branch
2 times, most recently
from
c35e8a4 to
72beea3
Compare
|
Have now tidied up, and is ready for review @pelwell Also, it complains about creating a new typedef - what would you like to do about this? - I know a previous comment suggested creating |
|
This is looking much better. You could replace the typedef with a structure whose only member is the two-dimensional array. And on that subject, is there any reason not to make it an array of |
bebon901
force-pushed
the
cmdline-working-splash
branch
from
72beea3 to
d4e2bec
Compare
|
Thanks! I've updated it to include your suggestions. |
bebon901
force-pushed
the
cmdline-working-splash
branch
from
d4e2bec to
f4a7526
Compare
|
when are you guys merging this in? |
pelwell
left a comment
pelwell
left a comment
There was a problem hiding this comment.
Just a few last-minute suggestions. I nearly hit the Merge button, but this is so close to being good...
Enable by adding the following to cmdline.txt: `fullscreen_logo_name=logo.tga fullscreen_logo=1` Will show the logo file present in /lib/firmware/ on the screen. This will be fullscreen and rendered early at boot. Any remaining space is filled with solid color from the image border. If TGA file is too big, image is clipped accordingly. Signed-off-by: Ben Benson <ben.benson@raspberrypi.com>
bebon901
force-pushed
the
cmdline-working-splash
branch
from
f4a7526 to
31d59a0
Compare
kernel: dmaengine: dw-axi-dmac: report per-channel max_burst via device_caps See: raspberrypi/linux#7011 kernel: Update tpm-slb9673-overlay.dts See: raspberrypi/linux#6993 kernel: Enable Full Screen Splash Images See: raspberrypi/linux#7005 kernel: overlays: Rebuild 5inch display from the 7inch See: raspberrypi/linux#7016
kernel: dmaengine: dw-axi-dmac: report per-channel max_burst via device_caps See: raspberrypi/linux#7011 kernel: Update tpm-slb9673-overlay.dts See: raspberrypi/linux#6993 kernel: Enable Full Screen Splash Images See: raspberrypi/linux#7005 kernel: overlays: Rebuild 5inch display from the 7inch See: raspberrypi/linux#7016
5 participants
This will allow users to enter a cmdline value which will enable the kernel to read a PPM file, and then rendering it fullscreen at the early boot stage.
I am aware it needs a lot of tidying up, but put here for others to reference!